-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate numerical label IDs to Yul #15969
Open
clonker
wants to merge
16
commits into
add_node_id_dispenser
Choose a base branch
from
numericalIds
base: add_node_id_dispenser
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,894
−3,592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7aa648
to
ba47427
Compare
ba47427
to
b45bcb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, nodes in the Yul AST are no longer referred to by string name (or more precisely: statically managed repository of strings and referenced by hashes thereof) but by numerical ID. The numerical ID belongs to an immutable
ASTLabelRegistry
, in which it is associated to a string label. In turn, the registry is owned by theyul::AST
.During, e.g., optimization it is possible to generate new
LabelID
s, which not yet have an associated label in a registry but encode a parent label (which may be empty) using theyul::LabelIDDispenser
. Newly generated IDs are only valid with respect to their generating instance ofLabelIDDispenser
.At the end of optimization, when f.ex. serialization back into a stringified form is required, the
LabelID
s currently contained in the AST are assigned new labels by theyul::LabelIDDispenser
, generating a new instance ofASTLabelRegistry
.This PR removes
YulString
,yul::NameSimplifier
,yul::NameDispenser
,yul::VarNameCleaner
and replaces them by theLabelID
and related utilities.There is a special case of ghost nodes. These are introduced in CFGs to map switch statements to sequences of if-else blocks but do not live in the actual AST, just the CFG. To this end, a CFG also holds an instance of
ASTLabelRegistry
and manages theLabelID
->string_view
transformation itself. AnASTLabelRegistry
itself does not know how to stringify the special ghost nodes.Depends on #15838.