Remove Yul VarNameCleaner

Author: clonker

libyul/CMakeLists.txt

@@ -198,8 +198,6 @@ add_library(yul
 	optimiser/UnusedPruner.h
 	optimiser/VarDeclInitializer.cpp
 	optimiser/VarDeclInitializer.h
-	optimiser/VarNameCleaner.cpp
-	optimiser/VarNameCleaner.h
 )
 
 target_link_libraries(yul PUBLIC evmasm solutil langutil smtutil fmt::fmt-header-only)

libyul/optimiser/Suite.cpp

@@ -57,7 +57,6 @@
 #include <libyul/optimiser/SyntacticalEquality.h>
 #include <libyul/optimiser/UnusedAssignEliminator.h>
 #include <libyul/optimiser/UnusedStoreEliminator.h>
-#include <libyul/optimiser/VarNameCleaner.h>
 #include <libyul/optimiser/LoadResolver.h>
 #include <libyul/optimiser/LoopInvariantCodeMotion.h>
 #include <libyul/optimiser/Metrics.h>
@@ -260,7 +259,6 @@ std::map<std::string, std::unique_ptr<OptimiserStep>> const& OptimiserSuite::all
 			UnusedPruner,
 			VarDeclInitializer
 		>();
-	// Does not include VarNameCleaner because it destroys the property of unique names.
 	// Does not include NameSimplifier.
 	return instance;
 }

libyul/optimiser/VarNameCleaner.cpp

@@ -22,7 +22,6 @@
 
 #include <libyul/optimiser/BlockFlattener.h>
 #include <libyul/optimiser/VarDeclInitializer.h>
-#include <libyul/optimiser/VarNameCleaner.h>
 #include <libyul/optimiser/ControlFlowSimplifier.h>
 #include <libyul/optimiser/DeadCodeEliminator.h>
 #include <libyul/optimiser/Disambiguator.h>

libyul/optimiser/VarNameCleaner.h

@@ -35,7 +35,6 @@
 #include <libyul/optimiser/Disambiguator.h>
 #include <libyul/optimiser/OptimiserStep.h>
 #include <libyul/optimiser/StackCompressor.h>
-#include <libyul/optimiser/VarNameCleaner.h>
 #include <libyul/optimiser/Suite.h>
 
 #include <libyul/backends/evm/EVMDialect.h>
@@ -202,7 +201,6 @@ class YulOpti
 			std::map<char, std::string> const& extraOptions = {
 				// QUIT starts with a non-letter character on purpose to get it to show up on top of the list
 				{'#', ">>> QUIT <<<"},
-				{',', "VarNameCleaner"},
 				{';', "StackCompressor"}
 			};
 
@@ -219,11 +217,6 @@ class YulOpti
 					case 4:
 					case '#':
 						return;
-					case ',':
-						VarNameCleaner::run(m_context, *m_astRoot);
-						// VarNameCleaner destroys the unique names guarantee of the disambiguator.
-						disambiguated = false;
-						break;
 					case ';':
 					{
 						Object obj;