-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy with Railway support #2578
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for deploying Wasp apps with the Railway CLI by adding new Railway-specific providers, commands, and helper functions. Key changes include the creation of new Railway deployment and launch modules, the extraction of common deployment options and helpers, and the integration of the Railway provider into the main deploy command.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
waspc/packages/deploy/src/providers/railway/launch/launch.ts | Implements the Railway launch function with error handling for setup and deploy steps. |
waspc/packages/deploy/src/providers/railway/launch/LaunchOptions.ts | Defines the interface for launch options specific to Railway. |
waspc/packages/deploy/src/providers/railway/index.ts | Registers Railway commands and global options into the CLI. |
waspc/packages/deploy/src/providers/railway/helpers/railwayHelpers.ts | Provides Railway-specific helper functions including CLI existence checks, login verification, and service URL retrieval. |
waspc/packages/deploy/src/providers/railway/helpers/ports.ts | Exports port constants used in Railway deployments. |
waspc/packages/deploy/src/providers/railway/deploy/deploy.ts | Contains the logic for deploying server and client builds to Railway. |
waspc/packages/deploy/src/providers/railway/deploy/DeployOptions.ts | Declares deployment options for the Railway provider. |
waspc/packages/deploy/src/providers/railway/DeploymentInfo.ts | Generates immutable deployment information including names for client, server, and database. |
waspc/packages/deploy/src/providers/railway/CommonOptions.ts | Declares common CLI options shared by Railway commands. |
Other Fly provider changes | Adjust import paths and leverage common helpers for consistency. |
waspc/packages/deploy/src/index.ts | Integrates the Railway command into the main CLI application. |
waspc/packages/deploy/src/helpers.ts | Centralizes utility functions used across providers. |
Comments suppressed due to low confidence (1)
waspc/packages/deploy/src/providers/railway/helpers/ports.ts:2
- [nitpick] Both serverAppPort and clientAppPort are set to 8080. Consider using distinct port values for client and server deployments if they are meant to run concurrently, or add a clarifying comment if using the same port is intentional.
export const clientAppPort = 8080;
Left to do:
Closes #1232