Parallelize Delta Lake checkpoint v2 sidecar files retrieval #25469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...n/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java
Show resolved
Hide resolved
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogAccess.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/CheckpointWriterManager.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/test/java/io/trino/plugin/deltalake/transactionlog/TestTableSnapshot.java
Outdated
Show resolved
Hide resolved
|
@raunaqmorarka Thanks for the review, all comments addressed |
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogAccess.java
Outdated
Show resolved
Hide resolved
...n/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java
Outdated
Show resolved
Hide resolved
chenjian2664
reviewed
Apr 3, 2025
...n/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java
Show resolved
Hide resolved
|
saw a few tests failed with my new revision, will fix them |
chenjian2664
reviewed
Apr 4, 2025
...n/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TableSnapshot.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/CheckpointWriterManager.java
Outdated
Show resolved
Hide resolved
zhaner08
force-pushed
the
support_parallel_sidecar_read_1
branch
from
ca88bb1 to
856364a
Compare
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
zhaner08
force-pushed
the
support_parallel_sidecar_read_1
branch
from
856364a to
bd03199
Compare
raunaqmorarka
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parallelize Delta Lake checkpoint v2 sidecar files retrieval.
This optimization will use a bounded executor out of the metadata executor service to process sidecar files in parallel, which normally take a few hundred milliseconds each depend on the file sizes and the effectiveness of the predicate pushdown into metadata. The retrieval of the futures and split generations will happen the same way as now which splits can be generated and consumed while future values are obtained.
This optimization may significantly improve the speeds of Delta Lake queries, especially those ones with large amount of metdata files.
A configuration
delta.checkpoint-processing.parallelismhas been provided in case users would like to speed up the metadata processing even more, or want to reduce the parallelism when having a smaller clusterThis PR also adds more tests for multipart v2 checkpoint validations
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: