This repository was archived by the owner on Jun 21, 2020. It is now read-only.
Refactoring the KM #286
Open
Refactoring the KM #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenpo
reviewed
Feb 6, 2020
Co-Authored-By: Reuven Podmazo <reuven@enigma.co>
Co-Authored-By: Reuven Podmazo <reuven@enigma.co>
# Conflicts: # enigma-principal/app/src/controller/config.json # enigma-principal/app/tests/principal_node/config/principal_test_config.json # enigma-principal/app/tests/principal_node/contracts/principal_test_config.json
reuvenpo
reviewed
Feb 6, 2020
reuvenpo
reviewed
Feb 6, 2020
enigma-principal/app/tests/principal_node/config/principal_test_config.json
Outdated
Show resolved
Hide resolved
reuvenpo
reviewed
Feb 6, 2020
reuvenpo
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed naming.
Error Handling.
Removed unnecessary structs.
made the code a bit more rustic.
The Integration tests are failing, work is needed to be done in order to locate the cause and fix it.