[data] deanonymize map operator actors #51962
Conversation
| @@ -170,7 +171,8 @@ def _start_actor(self): | |||
| if self._ray_remote_args_fn: | |||
| self._refresh_actor_cls() | |||
| actor = self._cls.options( | |||
| _labels={self._OPERATOR_ID_LABEL_KEY: self.id} | |||
| name=f"{self.name}.{uuid.uuid4()}", | |||
There was a problem hiding this comment.
note: actor name has to be unique in a ray cluster so we attach a unique id to every actor created
There was a problem hiding this comment.
if we do this. what will the actor chart look like on Grafana?
I guess we can no longer aggregate the actors by name, and each actor will be showing as an individual line?
There was a problem hiding this comment.
I'll attach a screen shot. But I think you can aggregate the actors by the name of the operator (no longer just _MapWorker, but the operator name). Each actor will be showing as individual line yes. The number of actor is in the order of number of operator basically.
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-datatask02
branch
from
0c570f5 to
ec445f0
Compare
|
@raulchen screenshot attached; need to end up changing some core code as well for this to work |
Following up from #51962, correct the name of the `submit` task. Test: - CI Signed-off-by: can <can@anyscale.com>
Following up from ray-project#51962, correct the name of the `submit` task. Test: - CI Signed-off-by: can <can@anyscale.com>
Currently when the _MapWorker actors are logged into promethetus, they all look the same as _MapWorker. This PR deanonymize these names, by attaching the map function name to these actors.
Test: