[Feat][Core/Dashboard] Remove dashboard gRPC server #51956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
force-pushed
the
feature/remove-dashboard-grpc-server
branch
from
4b6a372 to
8efce81
Compare
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
force-pushed
the
feature/remove-dashboard-grpc-server
branch
from
8efce81 to
f102661
Compare
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
requested review from
edoakes,
richardliaw,
jjyao and
a team
as code owners
jjyao
reviewed
Apr 4, 2025
| @@ -526,7 +526,6 @@ def print_after(_obj): | |||
|
|
|||
| def test_log_redirect_to_stderr(shutdown_only): | |||
| log_components = { | |||
| ray_constants.PROCESS_TYPE_DASHBOARD: "Dashboard head grpc address", | |||
There was a problem hiding this comment.
We should keep this but check a different log message
There was a problem hiding this comment.
Use "Starting dashboard metrics server on port" instead.
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
jjyao
approved these changes
Apr 6, 2025
|
cc @dayshah for the doc review. |
dayshah
approved these changes
Apr 6, 2025
| @@ -134,7 +134,7 @@ In addition to ports specified above, the head node needs to open several more p | |||
| - ``--port``: Port of Ray (GCS server). The head node will start a GCS server listening on this port. Default: 6379. | |||
| - ``--ray-client-server-port``: Listening port for Ray Client Server. Default: 10001. | |||
| - ``--redis-shard-ports``: Comma-separated list of ports for non-primary Redis shards. Default: Random values. | |||
| - ``--dashboard-grpc-port``: The gRPC port used by the dashboard. Default: Random value. | |||
| - ``--dashboard-grpc-port``: (Deprecated) No longer used. Only kept for backward compatibility. | |||
There was a problem hiding this comment.
when would we fully remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
After #51555, the dashboard gRPC server is not used by any modules. This PR removes it.
The CLI flag
--dashboard-grpc-portis kept but deprecated.Related issue number
N/A
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.