Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support merge 1-qubit gates for parameterized circuits #7149

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

babacry
Copy link
Collaborator

@babacry babacry commented Mar 17, 2025

Input: symbolized_circuit, sweep
Output: new_symbolzied_circuit, new_sweep

@babacry babacry force-pushed the merge_single branch 6 times, most recently from 3dea74b to d5da63a Compare March 18, 2025 02:09
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (0551f85) to head (c4751c5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7149      +/-   ##
==========================================
- Coverage   98.13%   98.13%   -0.01%     
==========================================
  Files        1093     1093              
  Lines       95528    95581      +53     
==========================================
+ Hits        93745    93797      +52     
- Misses       1783     1784       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Note: if users expect update sweeps together with merging, it's not
supported yet. It's a todo item to be supported in the followup PRs.
@babacry
Copy link
Collaborator Author

babacry commented Mar 18, 2025

Hi Eliott, Nour, I have added the function to support one use case. Could you PTAL? For the use case of combined input of sweep and parameterized circuit, will be added in the followup PR. Let's first make sure this PR is in the right place and do the right job. Thanks!

Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it a little bit in this colab, and it doesn't seem to work properly yet, the interface looks good to me.

@eliottrosenberg eliottrosenberg self-requested a review April 4, 2025 00:06
Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @babacry!!! I tested it here, and it seems to work!

@eliottrosenberg
Copy link
Collaborator

One small comment: it would be nice if the merged single-qubit gates ended up in the same moment; see this cell of the colab.

@babacry
Copy link
Collaborator Author

babacry commented Apr 4, 2025

Got you, thanks a lot for the manual checks! I will update the pr accordingly and fix checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants