-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support merge 1-qubit gates for parameterized circuits #7149
base: main
Are you sure you want to change the base?
Conversation
3dea74b
to
d5da63a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7149 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 1093 1093
Lines 95528 95581 +53
==========================================
+ Hits 93745 93797 +52
- Misses 1783 1784 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note: if users expect update sweeps together with merging, it's not supported yet. It's a todo item to be supported in the followup PRs.
Hi Eliott, Nour, I have added the function to support one use case. Could you PTAL? For the use case of combined input of sweep and parameterized circuit, will be added in the followup PR. Let's first make sure this PR is in the right place and do the right job. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it a little bit in this colab, and it doesn't seem to work properly yet, the interface looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment: it would be nice if the merged single-qubit gates ended up in the same moment; see this cell of the colab. |
Got you, thanks a lot for the manual checks! I will update the pr accordingly and fix checks. |
Input: symbolized_circuit, sweep
Output: new_symbolzied_circuit, new_sweep