Update check in SystemdService.exists and add tests #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarstenGrohmann
force-pushed
the
add_tests_for_service_exists
branch
2 times, most recently
from
603ce09 to
a7fcca2
Compare
CarstenGrohmann
changed the title
Merged
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
Apr 30, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
jsf9k
added a commit
to cisagov/ansible-role-systemd-resolved
that referenced
this pull request
May 3, 2024
This functionality from pytest-testinfra is currently broken. See pytest-dev/pytest-testinfra#757 for more details. Once pytest-dev/pytest-testinfra#754 has been merged and a new release of pytest-testinfra is created the Service.exists line can be restored.
|
Can anything be done to move this PR along? Is it waiting on something? I'm happy to help where I can. |
philpep
reviewed
Mar 31, 2025
testinfra/modules/service.py
Outdated
| # list-units: List all units that Systemd currently has in memory, | ||
| # this includes generated units like SysV files also | ||
| cmd = self.run_test( | ||
| r'systemctl list-units --all | grep -q "^[[:space:]]*%s"', self.name |
There was a problem hiding this comment.
On my machine (debian trixie) systemctl list-units --all does not display "postgresql.service" while systemctl list-unit-files does.
There was a problem hiding this comment.
You are rigth. Non of this commands provided a complete list of unit-files. Therefore, I'll provide an update within the next days.
There was a problem hiding this comment.
Commit 5d3f323 contains the improved check and executes both commands to check if the specified unit exists.
There was a problem hiding this comment.
What about rather using systemctl status <unit> and check for exit code (4 = does not exists, < 4 exists) ?
There was a problem hiding this comment.
That's a good idea. The updates branch contains this command to check the existance.
There was a problem hiding this comment.
The code runs fine w/o any failed checks now.
CarstenGrohmann
force-pushed
the
add_tests_for_service_exists
branch
4 times, most recently
from
e0b2e81 to
6990387
Compare
CarstenGrohmann
force-pushed
the
add_tests_for_service_exists
branch
3 times, most recently
from
f598ce2 to
67a866c
Compare
CarstenGrohmann
force-pushed
the
add_tests_for_service_exists
branch
from
67a866c to
9b09891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.