-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nevergrad: OnePlusOne Optimiser addition #576
base: main
Are you sure you want to change the base?
Conversation
@janosg
|
def _solve_internal_problem( | ||
self, problem: InternalOptimizationProblem, x0: NDArray[np.float64] | ||
) -> InternalOptimizeResult: | ||
print(problem.bounds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I have tried to print bound
This does not contain enough information to understand your problem. We need at least the following:
Ideally you follow this blogpost when describing problems you encounter.
What is your question or doubt? If I understand correctly, this is how most global optimizers behave.
Algorithms in optimagic can have as many options as you need and they can have any type. So it should not be a problem to allow complete configurability of the algorithm. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @janosg, I've corrected the error from my previous message. I've now added the OnePlusOne wrapper, and it's ready for your review. There's a setting to control the maximum optimization time in Nevergrad – any ideas for a more descriptive name? I'm still working on adding constraints. |
Hi @gulshan-123, thanks for the PR. I'll do a thorough review once your wrapper is feature complete. So here are just some quick comments to help you get there:
The documentation is an essential part of the PR and needs to convince us that you did a thorough job in exploring all the tuning parameters of the algorithm. |
OnePlusOne, as implemented in Nevergrad, is a variant of the (1+1)-Evolution Strategy. It operates by maintaining a single current solution
I will try this. |
I have written a basic structure of OnePlusOne optimisation wrapper.
Partially fixes #560