[WIP] Upgrading Elixir and dependencies #1402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently tests fail with the following log: |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| @@ -67,7 +67,7 @@ defmodule Cog.Command.Output do | |||
| # typed by the user. | |||
| defp redirection_error_message(errors) do | |||
| all_bad_redirects = errors | |||
| |> Enum.map(fn({_,r}) -> r end) | |||
| |> Enum.map(fn({_, r}) -> r end) | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
| @@ -133,7 +133,7 @@ defmodule Cog.Bootstrap do | |||
| # like the user was attempting to bootstrap via environment we will | |||
| # warn about the missing variables. | |||
| missing -> | |||
| Enum.each(missing, fn({k,_v}) -> Logger.info("Skipping bootstrap: Missing value for #{bootstrap_var_for(k)}.") end) | |||
| Enum.each(missing, fn({k, _v}) -> Logger.info("Skipping bootstrap: Missing value for #{bootstrap_var_for(k)}.") end) | |||
There was a problem hiding this comment.
Function body is nested too deep (max depth is 2, was 3).
| result = Repo.transaction fn -> | ||
| case bootstrap_from_env do | ||
| case bootstrap_from_env() do |
There was a problem hiding this comment.
Function body is nested too deep (max depth is 2, was 3).
| @@ -120,7 +120,7 @@ defmodule Cog.Bootstrap do | |||
| fields = ~w(username password email_address first_name last_name) | |||
| vars = | |||
| Enum.map(fields, fn(field) -> { field, System.get_env(bootstrap_var_for(field)) } end) | |||
| |> Enum.group_by(fn({_k,v}) -> if (v != nil), do: :found, else: :not_found end) | |||
| |> Enum.group_by(fn({_k, v}) -> if v != nil, do: :found, else: :not_found end) | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/operable/cog/pulls/1402. |
|
Will circle back to this at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading Elixir support to 1.5. At the same time, upgrading dependencies to support the upgrade.
Fixes #1393