test: improve getCallSites #57732
Open
test: improve getCallSites #57732
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57732 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 630 630
Lines 185055 185197 +142
Branches 36221 36300 +79
==========================================
+ Hits 166984 167140 +156
+ Misses 11043 10988 -55
- Partials 7028 7069 +41 🚀 New features to boost your workflow:
|
marco-ippolito
approved these changes
Apr 3, 2025
lpinca
approved these changes
Apr 3, 2025
legendecas
approved these changes
Apr 4, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
jakecastelli
added
the
commit-queue-rebase
jasnell
approved these changes
Apr 6, 2025
jakecastelli
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57732 ✔ Done loading data for nodejs/node/pull/57732 ----------------------------------- PR info ------------------------------------ Title test: improve getCallSites (#57732) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:add-lower-bound-range-test -> nodejs:main Labels test, author ready, needs-ci, commit-queue-rebase Commits 2 - test: fix the decimal fractions explaination - test: add test for frame count being 0.5 Committers 1 - Jake Yuesong Li <jake.yuesong@gmail.com> PR-URL: https://github.com/nodejs/node/pull/57732 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57732 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 02 Apr 2025 15:00:26 GMT ✔ Approvals: 4 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57732#pullrequestreview-2740219853 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57732#pullrequestreview-2740921315 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57732#pullrequestreview-2742890295 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57732#pullrequestreview-2745191389 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-06T13:05:44Z: https://ci.nodejs.org/job/node-test-pull-request/66082/ - Querying data for job/node-test-pull-request/66082/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 57732 From https://github.com/nodejs/node * branch refs/pull/57732/merge -> FETCH_HEAD ✔ Fetched commits as a2de5b9150da..9f614ba63daf -------------------------------------------------------------------------------- [main 130a6467ec] test: fix the decimal fractions explaination Author: Jake Yuesong Li <jake.yuesong@gmail.com> Date: Thu Apr 3 01:23:27 2025 +1030 1 file changed, 1 insertion(+), 1 deletion(-) [main 85456ce8ef] test: add test for frame count being 0.5 Author: Jake Yuesong Li <jake.yuesong@gmail.com> Date: Thu Apr 3 01:24:21 2025 +1030 1 file changed, 5 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: fix the decimal fractions explainationhttps://github.com/nodejs/node/actions/runs/14299097568 |
The frame count is between 1 and 200. Testing 0.5 will be testing decimal fraction truncation to 0 which is still invalid range.
|
On a new laptop, haven't moved all the config files across, forgot to |
jakecastelli
force-pushed
the
add-lower-bound-range-test
branch
from
9f614ba to
640def1
Compare
jakecastelli
removed
the
commit-queue-failed
legendecas
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dot-leftsupposed to bedot-rightThe frame count is between 1 and 200. Testing 0.5 will be testing decimal fraction truncation to 0 which is still invalid range.