src: improve error handling in process.env handling #57707
Closed
+52
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
anonrig
approved these changes
Apr 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/process-env-errorhandling
branch
from
0171633 to
1e109eb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Apr 5, 2025
| @@ -421,6 +440,7 @@ static Intercepted EnvGetter(Local<Name> property, | |||
| TraceEnvVar(env, "get", property.As<String>()); | |||
|
|
|||
| if (has_env) { | |||
| // ToLocalChecked here is ok since we check IsEmpty above. | |||
There was a problem hiding this comment.
Wouldn't it be worth refactoring to use ToLocal instead? (to clarify, I'm not asking you to do it, I'm curious is all, and I get that the current code would not crash as is, but might still be a good idea to refactor this for consistency sake)
There was a problem hiding this comment.
Possibly? Not that critical tho.
jasnell
added a commit
that referenced
this pull request
Apr 5, 2025
PR-URL: #57707 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 214e3d4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling by eliminating ToLocalChecked uses