doc: fix pseudo code in modules.md #57677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem was introduced in PR nodejs#38837.
|
Review requested:
|
nodejs-github-bot
added
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pseudo code involved in the change adds the
node_modulesdirectories closer and closer to the root directory toDIRS. The correct way should be to add it to the end, which is consistent with the actual behavior of Node.This problem was introduced in f77fe64 of PR #38837.
@Ayase-252 applied a change suggested by @guybedford, although they discovered that the change is wrong in a later conversation, the change was still merged.1
Footnotes
https://github.com/nodejs/node/pull/38837#discussion_r641990919 ↩