Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove frequent logs #41105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaofan-luan
Copy link
Collaborator

remove unnecessary logs on collecting metric info

@sre-ci-robot sre-ci-robot requested review from congqixia and sunby April 4, 2025 02:46
@xiaofan-luan xiaofan-luan added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 4, 2025
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 4, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dosubot dosubot bot added the area/logging label Apr 4, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (f18aa85) to head (9669b7f).

Files with missing lines Patch % Lines
internal/datacoord/metrics_info.go 0.00% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #41105   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files        1483     1483           
  Lines      209719   209722    +3     
=======================================
+ Hits       168971   168979    +8     
+ Misses      34625    34619    -6     
- Partials     6123     6124    +1     
Components Coverage Δ
Client 79.58% <ø> (ø)
Core 70.48% <ø> (-0.02%) ⬇️
Go 82.30% <0.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/metrics_info.go 82.84% <0.00%> (-0.82%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented Apr 4, 2025

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Copy link
Contributor

mergify bot commented Apr 4, 2025

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/logging dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants