Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prism configuration for select baremetal, qemu-guest, marketplace-gen1, and marketplace-gen2 images #13251

Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from

Conversation

vinceaperri
Copy link
Contributor

@vinceaperri vinceaperri commented Apr 1, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Adds Prism YAML configuration for the baremetal, qemu-guest, marketplace-gen1, and marketplace-gen2 images, for both x86_64 and aarch64 (where supported).

Change Log
  • Translated existing baremetal x86_64 JSON config to new Prism YAML config
  • Added new baremetal aarch64 Prism YAML config (size is the only change from the x86_64 config)
  • Translated existing qemu-guest x86_64 JSON config to new Prism YAML config
  • Added new qemu-guest aarch64 Prism YAML config (size again is the only change from the x86_64 config)
  • Translated existing marketplace-gen1 x86_64 JSON config to new Prism YAML config
  • Translated existing marketplace-gen2 x86_64 and aarch64 JSON config to new Prism YAML config
  • Translated all package lists used by the image configs above to Prism YAML configs
Does this affect the toolchain?

NO

@vinceaperri vinceaperri requested a review from a team as a code owner April 1, 2025 16:10
@microsoft-github-policy-service microsoft-github-policy-service bot added Schema Changes to image configurations 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 1, 2025
@vinceaperri vinceaperri changed the title Add Prism variant configuration for select image definitions Add Prism configuration for select image definitions Apr 1, 2025
@vinceaperri vinceaperri changed the title Add Prism configuration for select image definitions Add Prism configuration for select baremetal, qemu-guest, marketplace-gen1, and marketplace-gen2 images Apr 1, 2025
Copy link
Member

@reubeno reubeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we planning to keep these from diverging from the current JSON-based configurations? Can we instead auto-generate these? Or vice versa? Or add checks to ensure they're consistent?

Is there a long-term plan for deprecating the JSON configs?

partitions:
- id: esp
type: esp
start: 1M
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use size instead of start and end. Same comment elsewhere.

@@ -0,0 +1,27 @@
packages:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-image-packages and core-packages-image are kind of confusing names. I think you are copying the existing names from the json files. But I wonder if we should take the opportunity to improve the names somewhat.

- chrony
- cryptsetup
- dbus
- e2fsprogs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you are duplicating packages that are in the seed image?

@vinceaperri vinceaperri force-pushed the user/vinceaperri/variants-3.0-dev branch from c50587a to 7a36a33 Compare April 2, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Schema Changes to image configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants