-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prism configuration for select baremetal, qemu-guest, marketplace-gen1, and marketplace-gen2 images #13251
base: 3.0-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we planning to keep these from diverging from the current JSON-based configurations? Can we instead auto-generate these? Or vice versa? Or add checks to ensure they're consistent?
Is there a long-term plan for deprecating the JSON configs?
partitions: | ||
- id: esp | ||
type: esp | ||
start: 1M |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use size
instead of start
and end
. Same comment elsewhere.
@@ -0,0 +1,27 @@ | |||
packages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base-image-packages
and core-packages-image
are kind of confusing names. I think you are copying the existing names from the json files. But I wonder if we should take the opportunity to improve the names somewhat.
- chrony | ||
- cryptsetup | ||
- dbus | ||
- e2fsprogs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you are duplicating packages that are in the seed image?
…igs for x86_64 and aarch64
c50587a
to
7a36a33
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Adds Prism YAML configuration for the baremetal, qemu-guest, marketplace-gen1, and marketplace-gen2 images, for both x86_64 and aarch64 (where supported).
Change Log
Does this affect the toolchain?
NO