Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql minor changes and sysbench cleanup addition #454

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

mysql minor changes and sysbench cleanup addition #454

wants to merge 8 commits into from

Conversation

nmalkapuram
Copy link
Contributor

No description provided.

@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MYSQLchanges branch from c0ebb03 to 3972ccb Compare March 11, 2025 16:51
yangpanMS
yangpanMS reviewed Mar 12, 2025
View reviewed changes
src/VirtualClient/VirtualClient.Actions/Sysbench/sysbench scripts/cleanup-database.py Outdated
@@ -0,0 +1,22 @@
import subprocess, argparse, os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put these scripts in VC build and not mysql package? This way you make sure the code and script match in the same version, you don't have situation people running rev2 in their profile with new VC

@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MYSQLchanges branch from 9da99da to f22095a Compare March 24, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangpanMS yangpanMS yangpanMS left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmalkapuram @yangpanMS