Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: bump to containerd 2 #20507

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Mar 9, 2025

ISO: bump go version to 1.23
FIX #20497
CLOSE #20485

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha March 9, 2025 20:05
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2025
@ComradeProgrammer
Copy link
Member Author

ComradeProgrammer commented Mar 9, 2025

/ok-to-build-iso

@ComradeProgrammer
Copy link
Member Author

ComradeProgrammer commented Mar 9, 2025

/ok-to-build-image

@ComradeProgrammer
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 9, 2025
@ComradeProgrammer
Copy link
Member Author

ok-to-build-iso

@ComradeProgrammer
Copy link
Member Author

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @ComradeProgrammer, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@ComradeProgrammer
Copy link
Member Author

/ok-to-build-iso

@ComradeProgrammer
Copy link
Member Author

ok-to-build-iso

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented Mar 10, 2025

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2025
@ComradeProgrammer ComradeProgrammer changed the title ISO: bump go version to 1.23 ISO: bump to containerd 2 Mar 25, 2025
@k8s-ci-robot k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2025
@ComradeProgrammer
Copy link
Member Author

/ok-to-build-iso

@ComradeProgrammer
Copy link
Member Author

ComradeProgrammer commented Mar 25, 2025

/ok-to-build-iso

This should work, for now I guess. At least I can build the x86-64 iso successfully on my own machine

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@ComradeProgrammer
Copy link
Member Author

/ok-to-build-iso

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20507) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 52.6s               |
| enable ingress | 16.8s    | 17.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 20507) start: 50.7s 52.1s 53.4s 53.3s 53.4s
Times for minikube start: 52.7s 51.2s 51.2s 49.4s 51.7s

Times for minikube ingress: 16.6s 18.6s 14.7s 15.1s 19.2s
Times for minikube (PR 20507) ingress: 16.0s 18.6s 19.1s 18.6s 15.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20507) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 25.2s               |
| enable ingress | 12.5s    | 12.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 20507) ingress: 12.4s 12.4s 12.4s 12.4s 12.4s
Times for minikube ingress: 12.9s 12.4s 12.4s 12.4s 12.4s

Times for minikube start: 22.5s 23.1s 25.2s 23.4s 22.4s
Times for minikube (PR 20507) start: 26.4s 22.3s 25.3s 26.2s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20507) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 21.6s               |
| enable ingress | 38.9s    | 39.1s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 24.7s 24.0s 24.1s 24.6s
Times for minikube (PR 20507) start: 21.7s 21.0s 21.8s 21.5s 21.8s

Times for minikube ingress: 38.9s 38.9s 38.9s 38.9s 38.9s
Times for minikube (PR 20507) ingress: 38.9s 38.8s 39.9s 38.9s 38.9s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
KVM_Linux_crio (10 failed) TestFunctional/parallel/DashboardCmd(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

  • Docker_Linux_containerd_arm64: 12 failed (gopogh)

  • Docker_Linux_crio: 20 failed (gopogh)

  • Docker_Cloud_Shell: 3 failed (gopogh)

  • Docker_Linux: 16 failed (gopogh)

  • Docker_Linux_containerd: 16 failed (gopogh)

  • Docker_Linux_crio_arm64: 26 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to Containerd 2
5 participants