Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Containerd 2 #20497

Open
medyagh opened this issue Mar 5, 2025 · 4 comments · May be fixed by #20507
Open

Bump to Containerd 2 #20497

medyagh opened this issue Mar 5, 2025 · 4 comments · May be fixed by #20507
Assignees

Comments

@medyagh
Copy link
Member

medyagh commented Mar 5, 2025

#20485

currently the ISO Fails to build

we might need to bump some Version of dependecies in the ISO and Kic Base
in that case we need to make sure it is PreBaked for the Default Kubernetes version and other kubernetes versions can Download on the Fly or Get a user warnining

@ComradeProgrammer ComradeProgrammer self-assigned this Mar 9, 2025
@ComradeProgrammer ComradeProgrammer linked a pull request Mar 9, 2025 that will close this issue
@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 10, 2025

Previously containerd was included with docker, so it was only bumped when docker did.

https://docs.docker.com/engine/install/binaries/

$ ./docker --version
Docker version 28.0.1, build 068a01e
$ ./containerd --version
containerd github.com/containerd/containerd v1.7.25 bcc810d6b9066471b0b6fa75f557a15a1cbf31bb
$ ./runc --version
runc version 1.2.5
commit: v1.2.5-0-g59923ef
spec: 1.2.0
go: go1.23.6
libseccomp: 2.5.4

i.e. 1.7, rather than 2.0

@afbjorklund
Copy link
Collaborator

@medyagh
Copy link
Member Author

medyagh commented Mar 19, 2025

possible related issue kubernetes/kubernetes#130799

@ComradeProgrammer
Copy link
Member

As I have described in the previous triage meeting, the problem is this:

  • we never automatically update the version of buildroot in makefile, and it is locked on version 2023.02.9 , which is too old
  • at the meantime, this version build both go compiler from source. It use a 2-step-leap to build go(first build go 1.4 as a bootstrap, and then use go 1.4 to build go 1.19, and eventually use go 1.19 build the go compiler you want)
  • However, in containerd 2.0 it specifies that it requires golang 1.23. golang 1.23 requires at least golang>=1.21 as a bootstrap. using golang 1.19 to build it will cause a failure

This is the reason why previous CI fails.

The best solution seems to be: update buildroot to the newest version, but it will cause some other problems:

  • It seems that new version of buildroot has given up the 2-step-leap build for go bootstrap. Now in go.hash it requires the binary tarball instead of the sourcecode tarball. I added the hash of golang binary tarball file into go.hash
  • It seems that conmon is now a part of buildroot, and redeclare it in minikube's .mk file will cause an error. i removed it from our iso package and use the built-in conmon instead
  • falco cannot build. I haven't figured out why yet.

For now I am trying if we can build an iso without falco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants