Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation rules for streaming #531

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add validation rules for streaming #531

merged 1 commit into from
Mar 18, 2025

Conversation

serathius
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from roycaihw and seans3 March 18, 2025 18:19
@serathius serathius mentioned this pull request Mar 18, 2025
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2025
@serathius serathius force-pushed the validate-streaming branch from 1c841c5 to 2134378 Compare March 18, 2025 18:21
@serathius
Copy link
Contributor Author

/assign @jpbetz

@liggitt
Copy link
Member

liggitt commented Mar 18, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@serathius
Copy link
Contributor Author

@jpbetz is OOO
/assign @sttts

@serathius @liggitt
Add validation rules for streaming
0d9316e 
Co-authored-by: Jordan Liggitt <liggitt@google.com>
@serathius serathius force-pushed the validate-streaming branch from 2134378 to 0d9316e Compare March 18, 2025 18:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@serathius
Copy link
Contributor Author

Added tests

@serathius
Copy link
Contributor Author

/assign @Jefftree

@Jefftree
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, liggitt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit c8a335a into kubernetes:master Mar 18, 2025
7 checks passed
@serathius serathius mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@seans3 seans3 Awaiting requested review from seans3

Assignees

@jpbetz jpbetz

@sttts sttts

@liggitt liggitt

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@serathius @liggitt @Jefftree @k8s-ci-robot @jpbetz @sttts