Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy addons #17332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rifelpet
Copy link
Member

These have been deprecated for 5 years. Anyone still using the channels command to apply manifests from this directory can update the path in the command arguments to reference an older kops release branch

Support for legacy addons was removed in kops clusters running k8s 1.23 #12064

/hold for feedback

These have been deprecated for 5 years. Anyone still using the channels command to apply manifests from this directory can update the path in the command arguments to reference an older kops release branch
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rifelpet. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 28, 2025
@hakman
Copy link
Member

hakman commented Mar 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2025
@hakman
Copy link
Member

hakman commented Apr 1, 2025

/override tests-e2e-scenarios-bare-metal

@k8s-ci-robot
Copy link
Contributor

@hakman: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • tests-e2e-scenarios-bare-metal

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-linux-amd64
  • build-linux-arm64
  • build-macos-amd64
  • build-windows-amd64
  • deploy/netlify
  • pull-kops-build
  • pull-kops-e2e-k8s-aws-amazonvpc
  • pull-kops-e2e-k8s-aws-calico
  • pull-kops-e2e-k8s-gce-cilium
  • pull-kops-e2e-k8s-gce-ipalias
  • pull-kops-test
  • pull-kops-verify-boilerplate
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet
  • tide
  • verify-amd64
  • verify-arm64

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override tests-e2e-scenarios-bare-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Apr 1, 2025

/override tests-e2e-scenarios-bare-metal

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: tests-e2e-scenarios-bare-metal

In response to this:

/override tests-e2e-scenarios-bare-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants