Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP4322: add some clusterProfile property #5185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KEP4322: add some clusterProfile property #5185

wants to merge 3 commits into from

Conversation

ryanzhang-oss
Copy link
Contributor

Add the discussed cluster properties to the KEP4322

  • Issue link:
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ryanzhang-oss. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ryanzhang-oss
Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from JeremyOT and skitt March 4, 2025 07:44
@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2025
MikeSpreitzer
MikeSpreitzer reviewed Mar 4, 2025
View reviewed changes
keps/sig-multicluster/4322-cluster-inventory/README.md Outdated

##### count.node.k8s.io
It contains the total number of nodes in the k8s clusters
* The value is dynamic but not changing fast.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the nodes can be of different types, does a total count have much value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what percentage of k8s clusters have heterogenous vs homogeneous node so it might be useful for homogeneous clusters

zhiying-lin
zhiying-lin reviewed Mar 6, 2025
View reviewed changes
keps/sig-multicluster/4322-cluster-inventory/README.md
Here is the corresponding ClusterProfile API
```yaml
properties:
- name: group.customResource.k8s.io
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we include the version? consumer may need to know what's the latest version installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but CRD version might not show the real version. i.e argo CD version has been stuck in v1alpha1 forever.

cainelli
cainelli reviewed Mar 18, 2025
View reviewed changes
keps/sig-multicluster/4322-cluster-inventory/README.md
labels:
multicluster.x-k8s.io/clusterProfile: true
spec:
value: ["100.3.3.4:5683","qs-oar7gr9p.azmk8s.io:443"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be quoted to not be treated as an array?

Suggested change
value: ["100.3.3.4:5683","qs-oar7gr9p.azmk8s.io:443"]
value: '["100.3.3.4:5683","qs-oar7gr9p.azmk8s.io:443"]'

keps/sig-multicluster/4322-cluster-inventory/README.md
name: count.node.k8s.io
labels:
multicluster.x-k8s.io/clusterProfile: true
Spec:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other cases with upper case Spec

Suggested change
Spec:
spec:

keps/sig-multicluster/4322-cluster-inventory/README.md

Here is an example of a cluster-entrypoints.k8s.io ClusterProperty
```yaml
apiVersion: about.k8s.io/v1
Copy link

@cainelli cainelli Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep getting confused about it. The code is still v1alpha1, there is an open PR for v1beta1 and docs are v1.

keps/sig-multicluster/4322-cluster-inventory/README.md
labels:
multicluster.x-k8s.io/clusterProfile: true
Spec:
value: 120
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar as the previous comment.

Suggested change
value: 120
value: '120'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

@skitt skitt skitt left review comments

@cainelli cainelli cainelli left review comments

@MikeSpreitzer MikeSpreitzer MikeSpreitzer left review comments

@zhiying-lin zhiying-lin zhiying-lin left review comments

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ryanzhang-oss @k8s-ci-robot @munnerz @skitt @cainelli @MikeSpreitzer @zhiying-lin