Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 5067: Pod Generation KEP creation #5068

Merged
merged 1 commit into from
Feb 12, 2025
Merged

KEP 5067: Pod Generation KEP creation #5068

merged 1 commit into from
Feb 12, 2025

Conversation

natasha41575
Copy link
Contributor

  • One-line PR description: Create new KEP 5067: Pod Generation
  • Other comments:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 21, 2025
@natasha41575 natasha41575 mentioned this pull request Jan 21, 2025
Open
8 tasks
@natasha41575
Copy link
Contributor Author

/cc @tallclair

@natasha41575 natasha41575 changed the title KEP 5067: Initial KEP creation KEP 5067: Pod Generation KEP creation Jan 21, 2025
@tallclair tallclair self-assigned this Jan 22, 2025
sftim
sftim reviewed Jan 22, 2025
View reviewed changes
Copy link

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback; hope it helps

@natasha41575 natasha41575 marked this pull request as ready for review January 22, 2025 16:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
@natasha41575 natasha41575 force-pushed the pod-generation-KEP branch 6 times, most recently from a0da338 to 2539f5b Compare January 22, 2025 22:01
@tallclair
Copy link
Member

/assign @liggitt

Mind being the API approver for this?

johnbelamaric
johnbelamaric reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this for PRR. I think there is one update needed capturing the results of the kubelet behavior discussion.

@natasha41575 natasha41575 force-pushed the pod-generation-KEP branch 7 times, most recently from 81ec184 to 4626ecc Compare February 11, 2025 19:53
@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, mrunalp, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit d06bb81 into kubernetes:master Feb 12, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 12, 2025
@natasha41575 natasha41575 deleted the pod-generation-KEP branch February 12, 2025 21:25
@liggitt liggitt mentioned this pull request Feb 14, 2025
Merged
@shannonxtreme shannonxtreme mentioned this pull request Feb 19, 2025
Merged
@liggitt liggitt mentioned this pull request Feb 27, 2025
Merged
@natasha41575 natasha41575 mentioned this pull request Mar 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@liggitt liggitt Awaiting requested review from liggitt

@tallclair tallclair Awaiting requested review from tallclair

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@yujuhong yujuhong Awaiting requested review from yujuhong

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@liggitt liggitt

@dchen1107 dchen1107

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

@yujuhong yujuhong

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.33
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
10 participants
@natasha41575 @k8s-ci-robot @tallclair @liggitt @sftim @yujuhong @johnbelamaric @mrunalp @dchen1107 @SergeyKanzhelev