-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding "since" annotation to k8s nodes #7883
base: master
Are you sure you want to change the base?
fix: adding "since" annotation to k8s nodes #7883
Conversation
Signed-off-by: MenD32 <amit.mendelevitch@gmail.com>
Hi @MenD32. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MenD32 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: MenD32 <amit.mendelevitch@gmail.com>
Signed-off-by: MenD32 <amit.mendelevitch@gmail.com>
Signed-off-by: MenD32 <amit.mendelevitch@gmail.com>
…32/autoscaler into feat/node-cooldown-timer-annotation
Signed-off-by: MenD32 <amit.mendelevitch@gmail.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes bug where upon deployment restart, cluster-autoscaler resets the the node scaledown timer, which can cause nodes to never scale in extreme cases.
Which issue(s) this PR fixes:
Fixes #7873
Special notes for your reviewer:
this issue has already affected me, and I'm highly motivated to fix this ASAP. so I should be available during the next few days, in order to resolve this quickly. if you have a better way of fixing this HA issue, please suggest one 😄
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: