Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Update golangci-lint to v2.0.2 and adjust configuration #4752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨Update golangci-lint to v2.0.2 and adjust configuration #4752

wants to merge 1 commit into from

Conversation

dongjiang1989
Copy link
Contributor

This updates golangci-lint to v2.0.2 with the associated configuration in workflows and Makefile

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2025
@dongjiang1989
update golangci-lint v2
c4d90f1 
Signed-off-by: dongjiang <dongjiang1989@126.com>

fix warning Found unknown linters in //nolint directives: maligned

Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 force-pushed the update-golangci-lint-v2 branch from 17858d4 to c4d90f1 Compare April 3, 2025 03:36
@dongjiang1989
Copy link
Contributor Author

cc @camilamacedo86 /ptal

@Kuzuri247
Copy link
Contributor

I am working on this already

camilamacedo86
camilamacedo86 reviewed Apr 4, 2025
View reviewed changes
pkg/config/v3/config.go
@@ -234,7 +234,7 @@ func (c *Cfg) UpdateResource(res resource.Resource) error {
}

for i, r := range c.Resources {
if res.GVK.IsEqualTo(r.GVK) {
if res.IsEqualTo(r.GVK) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will not it change the behaviour?

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2025
camilamacedo86
camilamacedo86 requested changes Apr 5, 2025
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot but this one is not passing in the CI yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 requested changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dongjiang1989 @k8s-ci-robot @Kuzuri247 @camilamacedo86