Update training_with_built_in_methods.py #21098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify parameter name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21098 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 564 564
Lines 54124 54124
Branches 8411 8411
=======================================
Hits 44755 44755
Misses 7293 7293
Partials 2076 2076
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
he7d3r
commented
Mar 30, 2025
| @@ -620,8 +620,8 @@ def __getitem__(self, idx): | |||
| """ | |||
| To fit the model, pass the dataset instead as the `x` argument (no need for a `y` | |||
| argument since the dataset includes the targets), and pass the validation dataset | |||
| as the `validation_data` argument. And no need for the `batch_size` argument, since | |||
| the dataset is already batched! | |||
| as the `validation_data` argument. And no need for the `validation_batch_size` | |||
There was a problem hiding this comment.
Note how validation_batch_size is not specified (but batch_size is) on line 629 below:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify parameter name