Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVINO backend]: Implement numpy.identity #21083

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

11happy
Copy link
Contributor

@11happy 11happy commented Mar 24, 2025

Overview:

  • This PR implements support for numpy.identity operation

Testing:

  • A single Test for bfloat16 is failing on my local end, rest all are passing.
    Screenshot from 2025-03-24 06-02-41

CC:

Signed-off-by: 11happy <soni5happy@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (895a123) to head (9cec5c6).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21083      +/-   ##
==========================================
+ Coverage   82.65%   82.69%   +0.03%     
==========================================
  Files         564      564              
  Lines       54097    54140      +43     
  Branches     8406     8412       +6     
==========================================
+ Hits        44716    44769      +53     
+ Misses       7303     7296       -7     
+ Partials     2078     2075       -3     
Flag Coverage Δ
keras 82.50% <100.00%> (+0.03%) ⬆️
keras-jax 64.06% <0.00%> (+0.01%) ⬆️
keras-numpy 59.09% <0.00%> (-0.04%) ⬇️
keras-openvino 32.89% <100.00%> (+0.26%) ⬆️
keras-tensorflow 64.34% <0.00%> (-0.02%) ⬇️
keras-torch 64.10% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -26,7 +26,6 @@ NumpyDtypeTest::test_eye
NumpyDtypeTest::test_flip
NumpyDtypeTest::test_floor
NumpyDtypeTest::test_hstack
NumpyDtypeTest::test_identity
NumpyDtypeTest::test_inner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also remove NumpyArrayCreateOpsCorrectnessTest::test_identity line above to switch on the test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rkazants
Copy link
Contributor

rkazants commented Apr 3, 2025

Please fix the test:

FAILED keras/src/ops/numpy_test.py::NumpyDtypeTest::test_identity_bfloat16 - IndexError: map::at

Signed-off-by: 11happy <soni5happy@gmail.com>
@11happy
Copy link
Contributor Author

11happy commented Apr 5, 2025

I have fixed the dtype error @rkazants.
Thank you : )

@11happy 11happy requested a review from rkazants April 5, 2025 10:00
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants