-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenVINO backend]: Implement numpy.identity #21083
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: 11happy <soni5happy@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21083 +/- ##
==========================================
+ Coverage 82.65% 82.69% +0.03%
==========================================
Files 564 564
Lines 54097 54140 +43
Branches 8406 8412 +6
==========================================
+ Hits 44716 44769 +53
+ Misses 7303 7296 -7
+ Partials 2078 2075 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -26,7 +26,6 @@ NumpyDtypeTest::test_eye | |||
NumpyDtypeTest::test_flip | |||
NumpyDtypeTest::test_floor | |||
NumpyDtypeTest::test_hstack | |||
NumpyDtypeTest::test_identity | |||
NumpyDtypeTest::test_inner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also remove NumpyArrayCreateOpsCorrectnessTest::test_identity
line above to switch on the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Please fix the test:
|
Signed-off-by: 11happy <soni5happy@gmail.com>
I have fixed the dtype error @rkazants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fchollet, looks good to me. Recommend to merge
Overview:
Testing:
CC: