Updated numpy.flip using openvino opset #21057

Raghavyadav17 · 2025-03-18T04:50:54Z

Implemented all the necessary mentioned in the issue:

Provide decomposition in Python for numpy.flip using OpenVINO opset
Include tests by removing line corresponding to the implemented operation in excluded_concrete_tests.txt file.
create pytest.ini file and place it in the root directory of the clone repository. This file should contain the following content:
[pytest]
env =
KERAS_BACKEND=openvino

@rkazants please review this PR :)

Fixes [Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.flip operation openvinotoolkit/openvino#29359

p-wysocki · 2025-03-24T11:29:23Z

bump @rkazants

gbaned · 2025-03-25T07:28:18Z

Hi @Raghavyadav17 Can you please resolve the conflicts? Thank you!

Raghavyadav17 · 2025-03-25T07:47:39Z

@gbaned apologies for not looking at it earlier, will resolve it ASAP!!!

Raghavyadav17 · 2025-03-26T14:06:37Z

@gbaned resolved the conflict :)

rkazants · 2025-03-26T17:54:19Z

Pls do NOT merge!!!

rkazants · 2025-03-27T07:01:28Z

keras/src/backend/openvino/excluded_concrete_tests.txt

-NumpyDtypeTest::test_log1p
+NumpyDtypeTest::test_log10
+


revert this change.

rkazants · 2025-03-27T07:01:39Z

keras/src/backend/openvino/excluded_concrete_tests.txt

@@ -33,7 +33,8 @@ NumpyDtypeTest::test_isfinite
 NumpyDtypeTest::test_isinf
 NumpyDtypeTest::test_isnan
 NumpyDtypeTest::test_linspace
-NumpyDtypeTest::test_log1p
+NumpyDtypeTest::test_log10
+
 NumpyDtypeTest::test_log
 NumpyDtypeTest::test_logspace


please remove also NumpyDtypeTest::test_flip

rkazants · 2025-03-27T07:01:58Z

keras/src/backend/openvino/excluded_concrete_tests.txt

@@ -92,7 +93,7 @@ NumpyOneInputOpsCorrectnessTest::test_diag
 NumpyOneInputOpsCorrectnessTest::test_diagonal
 NumpyOneInputOpsCorrectnessTest::test_exp2
 NumpyOneInputOpsCorrectnessTest::test_expm1
-NumpyOneInputOpsCorrectnessTest::test_flip
+


remove this blank line. not needed

rkazants · 2025-03-27T07:02:32Z

keras/src/backend/openvino/numpy.py

 def log1p(x):
-    raise NotImplementedError("`log1p` is not supported with openvino backend")
+    x=get_ov_output(x)
+    one=ov_opset.constant(1.0,dtype=x.dtype)
+    return OpenVINOKerasTensor(ov_opset.log(ov_opset.add(x,one)).output(0))
+


why it is here? It is needed for different PR. pls remove

@rkazants my bad will remove it !!

rkazants · 2025-03-27T07:02:44Z

pytest.ini

+[pytest]
+env =
+    KERAS_BACKEND=openvino


remove this file

rkazants · 2025-03-27T07:02:51Z

requirements.txt

 torch==2.6.0+cpu
-torch-xla==2.6.0;sys_platform != 'darwin'
+#torch-xla==2.6.0;sys_platform != 'darwin'



Raghavyadav17 · 2025-03-27T07:22:54Z

hi @rkazants working on the fixing the reviewed changes asap

Raghavyadav17 · 2025-03-30T07:52:30Z

@rkazants hi roman, made all the necessary changes you mentioned, please review them !!
Thanks

codecov-commenter · 2025-04-01T08:33:41Z

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (6e688ab) to head (d92cf16).
Report is 26 commits behind head on master.

Files with missing lines	Patch %	Lines
keras/src/backend/openvino/numpy.py	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21057      +/-   ##
==========================================
- Coverage   82.47%   80.15%   -2.32%     
==========================================
  Files         563      564       +1     
  Lines       53834    54138     +304     
  Branches     8359     8412      +53     
==========================================
- Hits        44401    43396    -1005     
- Misses       7392     8725    +1333     
+ Partials     2041     2017      -24

Flag	Coverage Δ
keras	`79.97% <0.00%> (-2.33%)`	⬇️
keras-jax	`64.07% <0.00%> (+0.27%)`	⬆️
keras-numpy	`59.09% <0.00%> (+0.33%)`	⬆️
keras-openvino	`?`
keras-tensorflow	`64.35% <0.00%> (+0.24%)`	⬆️
keras-torch	`64.11% <0.00%> (+0.28%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Raghavyadav17 · 2025-04-02T06:34:28Z

@rkazants hi Roman hope you're doing well;
do I manually fix the code format ? or do i use any commands ?

rkazants · 2025-04-03T10:02:00Z

Not correct implementation:

FAILED keras/src/ops/numpy_test.py::NumpyOneInputOpsCorrectnessTest::test_flip - AttributeError: module 'openvino.runtime.opset14' has no attribute 'Reverse'. Did you mean: 'inverse'?
= 1 failed, 2764 passed, 4073 skipped, 76 xfailed, 4 xpassed, 1 warning in 96.17s (0:01:36) =

Raghavyadav17 · 2025-04-03T14:53:12Z

@rkazants i'll have it fixed by today!!!

Raghavyadav17 added 2 commits March 17, 2025 12:50

added changes to support numpy.log1p op

c929212

added the required features

e5ede62

google-ml-butler bot added the size:S label Mar 18, 2025

google-ml-butler bot assigned gbaned Mar 18, 2025

Raghavyadav17 changed the title ~~Raghav/29359~~ Updated numpy.flip using openvino opset Mar 18, 2025

gbaned requested a review from mattdangerw March 18, 2025 11:55

google-ml-butler bot added the awaiting review label Mar 18, 2025

rkazants reviewed Mar 27, 2025

View reviewed changes

pytest.ini Outdated

Comment on lines 1 to 3

[pytest]

env =

KERAS_BACKEND=openvino

Copy link

Contributor

rkazants Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

rkazants reviewed Mar 27, 2025

View reviewed changes

Made changes mentioned by Roman

d92cf16

Raghavyadav17 force-pushed the raghav/29359 branch from 2316acb to d92cf16 Compare March 30, 2025 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated numpy.flip using openvino opset #21057

Updated numpy.flip using openvino opset #21057

Raghavyadav17 commented Mar 18, 2025 •

edited

Loading

p-wysocki commented Mar 24, 2025

gbaned commented Mar 25, 2025

Raghavyadav17 commented Mar 25, 2025

Raghavyadav17 commented Mar 26, 2025

rkazants commented Mar 26, 2025

rkazants Mar 27, 2025

rkazants Mar 27, 2025

rkazants Mar 27, 2025

rkazants Mar 27, 2025

Raghavyadav17 Mar 30, 2025

rkazants Mar 27, 2025

rkazants Mar 27, 2025

Raghavyadav17 commented Mar 27, 2025

Raghavyadav17 commented Mar 30, 2025

codecov-commenter commented Apr 1, 2025 •

edited

Loading

Raghavyadav17 commented Apr 2, 2025

rkazants commented Apr 3, 2025

Raghavyadav17 commented Apr 3, 2025 •

edited

Loading

		NumpyDtypeTest::test_log1p
		NumpyDtypeTest::test_log10

Updated numpy.flip using openvino opset #21057

Are you sure you want to change the base?

Updated numpy.flip using openvino opset #21057

Conversation

Raghavyadav17 commented Mar 18, 2025 • edited Loading

p-wysocki commented Mar 24, 2025

gbaned commented Mar 25, 2025

Raghavyadav17 commented Mar 25, 2025

Raghavyadav17 commented Mar 26, 2025

rkazants commented Mar 26, 2025

rkazants Mar 27, 2025

Choose a reason for hiding this comment

rkazants Mar 27, 2025

Choose a reason for hiding this comment

rkazants Mar 27, 2025

Choose a reason for hiding this comment

rkazants Mar 27, 2025

Choose a reason for hiding this comment

Raghavyadav17 Mar 30, 2025

Choose a reason for hiding this comment

rkazants Mar 27, 2025

Choose a reason for hiding this comment

rkazants Mar 27, 2025

Choose a reason for hiding this comment

Raghavyadav17 commented Mar 27, 2025

Raghavyadav17 commented Mar 30, 2025

codecov-commenter commented Apr 1, 2025 • edited Loading

Codecov Report

Raghavyadav17 commented Apr 2, 2025

rkazants commented Apr 3, 2025

Raghavyadav17 commented Apr 3, 2025 • edited Loading

Raghavyadav17 commented Mar 18, 2025 •

edited

Loading

codecov-commenter commented Apr 1, 2025 •

edited

Loading

Raghavyadav17 commented Apr 3, 2025 •

edited

Loading