Fix incorrect reference to model in Transformer class #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: correct model reference to self in Transformer class Changed model.compute_loss() to self.compute_loss() in train_step and test_step methods to properly reference the class instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the train_step and test_step methods of the Transformer class, there's a reference to model.compute_loss() which should be self.compute_loss() instead. Since we're inside the class methods, we should use self to refer to the current instance of the model.
Files Changed:
transformer_asr.py
Changes Made:
Replaced model.compute_loss() with self.compute_loss() in both train_step and test_step methods
Impact:
This correction ensures proper access to the parent class's compute_loss method through the correct instance reference. The original code would raise a NameError since model is not defined in this context, while self properly refers to the current Transformer instance.