Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qwen - Fix Preset Loader + Add Causal LM Test #2193

Merged
merged 3 commits into from
Apr 6, 2025

Conversation

heyyanshuman
Copy link
Collaborator

This PR fixes the backbone config loading in qwen preset loading script

@heyyanshuman heyyanshuman changed the title Qwen - Load tie embedding param from config Qwen - Fix Preset Loader + Add Causal LM Test Apr 2, 2025
@laxmareddyp laxmareddyp added the kokoro:force-run Runs Tests on GPU label Apr 2, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Apr 2, 2025
@heyyanshuman
Copy link
Collaborator Author

Looks like Tensorflow-GPU job fails due to CI timeout !

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Apr 4, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Apr 4, 2025
def setUp(self):
self.vocab = ["!", "air", "Ġair", "plane", "Ġat", "port"]
self.vocab += ["<|endoftext|>"]
# self.vocab += ["<|start_header_id|>", "<|end_header_id|>"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @shivance - left a NIT comment

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Apr 4, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Apr 4, 2025
@divyashreepathihalli divyashreepathihalli merged commit 2036b54 into keras-team:master Apr 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants