-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance deduplication rules provisioning with provider support and environment configuration #4399
base: main
Are you sure you want to change the base?
feat: enhance deduplication rules provisioning with provider support and environment configuration #4399
Conversation
…and environment configuration
@tuantran0910 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
…es in provisioning
Hmm, storing the hash value when provisioning in local file storage might not be a good way when we have many backend replicas as mentioned in this issue #4398. Solved by use other |
…e instead of only local file
…isted_or_new_session
hey @tuantran0910 - although we want to get this functionality, we feel it's a bit over-engineering here. let's sync if see if there is simpler solution for that. |
Hi @shahargl, I completely agree with you. We always aim for the simplest solution to our problems. I don’t have much experience before, so I would really appreciate any advice you could share. Thanks! :D |
Closes #4401
📑 Description
To make the provider configurations to be updated, so I think we should:
So each time the backend starts, restarts, ... The progress re-provisioning providers will happen. What if each time the backend restarts, the configurations not change, so I think we first calculate the hash of the configurations, then save it in either Redis or secret manager.
✅ Checks