fix deepspeed job #37284
Open
fix deepspeed job #37284
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
ydshieh
commented
Apr 4, 2025
| @@ -382,7 +382,7 @@ jobs: | |||
| run: pip freeze | |||
|
|
|||
| - name: Set `machine_type` for report and artifact names | |||
| working-directory: /transformers | |||
| working-directory: ${{ inputs.working-directory-prefix }}/transformers | |||
There was a problem hiding this comment.
only this is relevant
other changes to be reverted before merge
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
force-pushed
the
fix_deepspeed_job
branch
from
bc05d2f to
2e2e66d
Compare
|
cc @S1ro1 (not sure if relevant however) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Wrong
working_directoryand gotAlso install some packages at specific versions.
The pytest command is running with these changes
https://github.com/huggingface/transformers/actions/runs/14269422275/job/39998982497
I will leave you people to update the deepspeed docker image however: it's quite old.