Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose blip2qformer #37254

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alex-jw-brooks
Copy link
Contributor

This PR exposes Blip2QFormer so that it can be created via AutoModel.from_config, which is needed for making the projector component in granite speech generic (discussed in this PR).

Blip2QFormer is most of the way there already - this PR just:

  • Handles AutoModel registration
  • Adds docstrings / more information on forward inputs

Note that Blip2QFormer is already tested pretty extensively though the blip2 tests, and will also be tested through granite speech tests.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker can you please take a look?

@github-actions github-actions bot marked this pull request as draft April 3, 2025 16:19
Copy link

github-actions bot commented Apr 3, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@alex-jw-brooks alex-jw-brooks marked this pull request as ready for review April 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant