Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Virtual Try-On notebook to use Gemini 2.5 for segmentation mask. #661

Merged
merged 3 commits into from
Apr 6, 2025

Conversation

NSTiwari
Copy link
Contributor

@NSTiwari NSTiwari commented Apr 4, 2025

Hi @Giom-V,

Updated Virtual Try-On notebook to use Gemini 2.5 for segmentation mask. Could you please review?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Apr 4, 2025
Giom-V
Giom-V previously approved these changes Apr 4, 2025
@Giom-V
Copy link
Collaborator

Giom-V commented Apr 4, 2025

@NSTiwari Thanks for the quick update! It really works well!
Can you just add this link after the main title
<a target=\"_blank\" href=\"https://colab.research.google.com/github/google-gemini/cookbook/blob/main/examples/Virtual_Try_On.ipynb\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" height=30/>.
And also run the formatting script so I can do the merge?

Thanks again!

@NSTiwari
Copy link
Contributor Author

NSTiwari commented Apr 4, 2025

@NSTiwari Thanks for the quick update! It really works well! Can you just add this link after the main title <a target=\"_blank\" href=\"https://colab.research.google.com/github/google-gemini/cookbook/blob/main/examples/Virtual_Try_On.ipynb\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" height=30/>. And also run the formatting script so I can do the merge?

Thanks again!

@Giom-V done! You may please review and merge.

Few points:

  1. I've moved the old implementation (using SAM 2.1) to my personal repository and added its link to the current notebook.

  2. The link to Virtual Try-On notebook in Spatial_understanding.ipynb seems to be broken. Could you please fix it?
    image

@Giom-V
Copy link
Collaborator

Giom-V commented Apr 6, 2025

  1. I've moved the old implementation (using SAM 2.1) to my personal repository and added its link to the current notebook.

Good idea!

  1. The link to Virtual Try-On notebook in Spatial_understanding.ipynb seems to be broken. Could you please fix it?

Yes, good catch, I'll fix it.

@Giom-V
Copy link
Collaborator

Giom-V commented Apr 6, 2025

The notebook is still not formatted, but I'll fix that while fixing the link. Thanks for updating the notebook @NSTiwari!

@Giom-V Giom-V merged commit f5084f9 into google-gemini:main Apr 6, 2025
4 of 5 checks passed
@NSTiwari
Copy link
Contributor Author

NSTiwari commented Apr 6, 2025

The notebook is still not formatted, but I'll fix that while fixing the link. Thanks for updating the notebook @NSTiwari!

Thank you for merging, @Giom-V. About formatting the notebook, I did run the following commands:

!python3 -m pip install -U --user git+https://github.com/tensorflow/docs

!python3 -m tensorflow_docs.tools.nbfmt Virtual_Try_On.ipynb

Am I missing something?

@omkenge
Copy link
Contributor

omkenge commented Apr 6, 2025

@NSTiwari Can you try this
python3 -m tensorflow_docs.tools.nbfmt examples/Virtual_Try_On.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants