llama-bench: enhance benchmark with improved token throughput measurements

[thevishalagarwal]

This PR adds separate measurements for prompt processing and token generation throughput in llama-bench. The changes allow for more detailed performance analysis by separately tracking and reporting:

• Prompt processing throughput (prompt t/s)
• Token generation throughput (gen t/s)

The current implementation of t/s throughput metric is incorrect when -pg flag is specified. It uses the formula (n_prompt+n_gen)/e2e_time which does not accurately represent throughput and leads to misleading interpretation.

Benefits

• More accurate and granular performance metrics
• Better visibility into prompt processing vs token generation performance

Old output

> .llama-bench.exe -m C:\drive\models\gguf\Qwen2.5-0.5B-Instruct-Q4_K_M.gguf -pg 512,128 -pg 1000,200
ggml_cuda_init: found 1 CUDA devices:
  Device 0: NVIDIA GeForce RTX 4080, compute capability 8.9, VMM: yes
| model                          |       size |     params | backend    | ngl |          test |                  t/s |
| ------------------------------ | ---------: | ---------: | ---------- | --: | ------------: | -------------------: |
| qwen2 1B Q4_K - Medium         | 373.71 MiB |   494.03 M | CUDA       |  99 |         pp512 |    39230.93 ± 650.08 |
| qwen2 1B Q4_K - Medium         | 373.71 MiB |   494.03 M | CUDA       |  99 |         tg128 |       496.01 ± 17.34 |
| qwen2 1B Q4_K - Medium         | 373.71 MiB |   494.03 M | CUDA       |  99 |   pp512+tg128 |       2292.94 ± 4.15 |
| qwen2 1B Q4_K - Medium         | 373.71 MiB |   494.03 M | CUDA       |  99 |  pp1000+tg200 |      2644.50 ± 14.50 |

New output

> .\llama-bench.exe -m C:\drive\models\gguf\Qwen2.5-0.5B-Instruct-Q4_K_M.gguf -pg 512,128 -pg 1000,200
ggml_cuda_init: found 1 CUDA devices:
  Device 0: NVIDIA GeForce RTX 4080, compute capability 8.9, VMM: yes
| model                          |     params | backend    | ngl |          test |         prompt t/s |         gen t/s |
| ------------------------------ | ---------: | ---------- | --: | ------------: | -----------------: | --------------: |
| qwen2 1B Q4_K - Medium         |   494.03 M | CUDA       |  99 |         pp512 |  38748.35 ± 423.86 |     0.00 ± 0.00 |
| qwen2 1B Q4_K - Medium         |   494.03 M | CUDA       |  99 |         tg128 |        0.00 ± 0.00 |  491.16 ± 10.18 |
| qwen2 1B Q4_K - Medium         |   494.03 M | CUDA       |  99 |   pp512+tg128 | 38858.78 ± 2789.38 |   467.41 ± 9.05 |
| qwen2 1B Q4_K - Medium         |   494.03 M | CUDA       |  99 |  pp1000+tg200 |  38071.20 ± 956.56 |   462.01 ± 5.57 |

[JohannesGaessler]

My personal opinion is that a rate of tokens over both prompt processing and token generation is not a useful metric. This is because you are calculating the average of two clearly different phases of execution. I think a better metric would be just the total runtime of the test. Related discussion: #7199 . In any case, I think the way the information is presented with this PR is an improvement over master and I would still be willing to review and merge it unless someone else objects.

Other considerations:

• With these changes the documentation in the README file has become outdated, please update it prior to merging.
• The line width of the default prints is becoming too long I think. I would be fine with dropping the model size and number of parameters.
• I assume this Pr will have broken scripts/compare_llama_bench.py. It would be nice if this was fixed but I'm also fine with doing the fix myself.

[0cc4m]

I agree that there is room for improvement here. I have never used the pp+tg tests because the output didn't give me any useful information, so I would like that to change. The way this is handled by other applications is by calculating the combined pp+tg number as the total test time divided by the number of tokens generated. This gives you a useful metric of how fast you can generate tokens in back-to-back requests with a specific prompt size to process each time.

I don't think we should extend the table with separate pp and tg t/s counts, since the default tests keep them on separate rows anyways. That would only make sense if we wanted to default to pp+tg tests (which can also be discussed).

[JohannesGaessler]

The way this is handled by other applications is by calculating the combined pp+tg number as the total test time divided by the number of tokens generated. This gives you a useful metric of how fast you can generate tokens in back-to-back requests with a specific prompt size to process each time.

I disagree, that is in my view not a useful metric for comparison because the value that the rate is normalized to doesn't make sense.

I don't think we should extend the table with separate pp and tg t/s counts, since the default tests keep them on separate rows anyways. That would only make sense if we wanted to default to pp+tg tests (which can also be discussed).

What I think would be useful as a default for a table is generating some amount of tokens on an empty context and then the same amount of tokens with a non-empty context. From that you can roughly estimate both the maximum speed and how that speed declines with more context.

What I would think would be best but also high-effort would be to first record the prompt processing and generation evaluation times in a differential way. Then, in a second step you could fit a polynomial to the runtime as a function of context size and plot the results. A t/s value as a function of context size can be obtained by transforming the y axis.

[thevishalagarwal]

My personal opinion is that a rate of tokens over both prompt processing and token generation is not a useful metric. This is because you are calculating the average of two clearly different phases of execution. I think a better metric would be just the total runtime of the test.

Thanks for the review. I agree that e2e t/s is not a very useful metric. Separate pp and tg metrics are more useful to understand as these are two distinct phases. Total runtime is also not very helpful IMO since the runtime will vary based on the prompt length and the number of tokens generated and the total runtime doesn't give much insight on perf for either prompt or generation phase.

Instead of total runtime, a better metric is time to first token (TTFT). This is alternative to pp t/s. We can use TTFT if no one has any objection.

IMO, the separate pp and tg tests doesn't make sense either. However, we should keep pp+tg tests as default (if others agree). This is also consistent with other LLM-related libraries.

My final recommendation will be

• use TTFT and tg t/s as metrics
• remove separate pp and tg tests as default. Prefer pp+tg tests

[JohannesGaessler]

use TTFT and tg t/s as metrics

No, I think for pp and tg on their own it makes more sense to provide t/s instead of the runtime, I only think it doesn't make sense to provide a t/s value for a mixture of pp and t/g.

[thevishalagarwal]

Separate metrics for pp/tg and pp+tg tests is confusing and I don't think we should do that

[0cc4m]

The way this is handled by other applications is by calculating the combined pp+tg number as the total test time divided by the number of tokens generated. This gives you a useful metric of how fast you can generate tokens in back-to-back requests with a specific prompt size to process each time.

I disagree, that is in my view not a useful metric for comparison because the value that the rate is normalized to doesn't make sense.

Why? Tokens generated is the metric that the user cares about. Sure, it's less relevant than splitting up the metrics, but it is not useless.

I agree with a text generation test for empty and full context to get min and max expected speeds. A graph is even better, but would take too long to measure to make it the default.

[JohannesGaessler]

Why? Tokens generated is the metric that the user cares about. Sure, it's less relevant than splitting up the metrics, but it is not useless.

The relevant metrics for a good user experience as I see them are a low latency until the first token is generated and a high rate of tokens during generation. But because the initial latency is relative to the length of the prompt it makes more sense to instead provide a rate at which tokens are processed. On a fundamental level, if more metrics are to be added they need to be justified in some way, either by providing useful information on their own or by facilitating comparisons. I don't see a situation where a rate of tokens relative to the runtime of pp + tg is ever useful information in isolation. And for comparisons of some pp + tg runs the total runtime is a better metric because lower/higher values correlate better with better/worse performance.

[thevishalagarwal]

Updated the PR with prompt and gen t/s only and also updated README

[JohannesGaessler]

I think the PR in its current state is good and a straight upgrade over master. To take better advantage of the new functionality I would suggest changing the default mode to -r 3 -p 0 -n 32 -pg 4096,32. In my testing ~4096 context is enough to get you good sensitivity to the slowdown of a filled context and it's still sufficiently precise. One concern could be that if pp is slow then these defaults would take comparatively longer but for the backends that I work with I think this will not be an issue.

Example output:

johannesg@johannes-romed82t-00 ~/Projects/llama.cpp                                                                                                                  [11:43:35]
> $ ./bench --model models/opt/${model_name}-${quantization}.gguf -fa 0,1 -r 3 -p 0 -n 32 -pg 4096,32                                                         [±fa6cb8aec ●(✹)]
ggml_cuda_init: GGML_CUDA_FORCE_MMQ:    no
ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no
ggml_cuda_init: found 1 CUDA devices:
  Device 0: NVIDIA GeForce RTX 4090, compute capability 8.9, VMM: yes
| model                          |     params | backend    | ngl | fa |          test |         prompt t/s |         gen t/s |
| ------------------------------ | ---------: | ---------- | --: | -: | ------------: | -----------------: | --------------: |
| llama 8B Q4_0                  |     8.03 B | CUDA       |  99 |  0 |          tg32 |        0.00 ± 0.00 |   161.30 ± 0.08 |
| llama 8B Q4_0                  |     8.03 B | CUDA       |  99 |  0 |   pp4096+tg32 |     7954.03 ± 4.12 |   136.15 ± 0.31 |
| llama 8B Q4_0                  |     8.03 B | CUDA       |  99 |  1 |          tg32 |        0.00 ± 0.00 |   163.38 ± 0.03 |
| llama 8B Q4_0                  |     8.03 B | CUDA       |  99 |  1 |   pp4096+tg32 |    12723.48 ± 1.46 |   145.96 ± 0.14 |

build: fa6cb8aec (5100)

[thevishalagarwal]

Updated the default params

[JohannesGaessler]

Please update the README to reflect the change in defaults, it's enough to just modify the commands that produced the outputs where applicable. From my end I think the changes are otherwise good to merge.

[JohannesGaessler]

Actually, also change what is being listed as defaults in the README.

[thevishalagarwal]

Thanks for the review @JohannesGaessler

[JohannesGaessler]

This is missing the point of the example, do the test with ./llama-bench -n 0 -pg 0,0 -p 1024 -b 128,256,512,1024 instead.

[JohannesGaessler]

I didn't notice this before, but this example is supposed to show the effect of varying the number of threads. This does not have an effect with CUDA, please replace these numbers with a benchmark of the CPU backend. Since the CPU backend is comparatively slow I'd recommend doing the test with -pg 0,0 and adding that to the listed command.

[slaren]

The output of llama-bench is already too wide and I really don't like adding a column that is most of the time going to be wasted space. Instead, I propose adding a parameter that specifies at what depth in the context the test should be run. Include the value of this parameter in the test column rather than adding a new one. For example:

$ llama-bench -d 1024

| model                          |       size |     params | backend    | ngl |          test |                  t/s |
| ------------------------------ | ---------: | ---------: | ---------- | --: | ------------: | -------------------: |
| llama 7B Q4_0                  |   3.56 GiB |     6.74 B | CUDA       |  99 |  pp512 @ 1024 |      6082.24 ± 16.44 |
| llama 7B Q4_0                  |   3.56 GiB |     6.74 B | CUDA       |  99 |  tg128 @ 1024 |        170.76 ± 0.48 |

$ llama-bench -d 0,1024

| model                          |       size |     params | backend    | ngl |          test |                  t/s |
| ------------------------------ | ---------: | ---------: | ---------- | --: | ------------: | -------------------: |
| llama 7B Q4_0                  |   3.56 GiB |     6.74 B | CUDA       |  99 |         pp512 |      7082.24 ± 16.44 |
| llama 7B Q4_0                  |   3.56 GiB |     6.74 B | CUDA       |  99 |         tg128 |        270.76 ± 0.48 |
| llama 7B Q4_0                  |   3.56 GiB |     6.74 B | CUDA       |  99 |  pp512 @ 1024 |      6082.24 ± 16.44 |
| llama 7B Q4_0                  |   3.56 GiB |     6.74 B | CUDA       |  99 |  tg128 @ 1024 |        170.76 ± 0.48 |