Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop even more deprecated stuff #4193

Open
wants to merge 5 commits into
base: potel-base
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 25, 2025

Drop:

  • setting Scope.transaction directly
  • old way of setting failed_request_status_codes
  • setting the span argument of Scope.trace_propagation_meta
  • setting Scope.user directly

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.52%. Comparing base (bff8fdd) to head (e3da71f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/django/__init__.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4193      +/-   ##
==============================================
+ Coverage       83.47%   83.52%   +0.05%     
==============================================
  Files             143      143              
  Lines           14678    14596      -82     
  Branches         2332     2310      -22     
==============================================
- Hits            12252    12192      -60     
+ Misses           1709     1686      -23     
- Partials          717      718       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/_wsgi_common.py 82.45% <100.00%> (-0.75%) ⬇️
sentry_sdk/integrations/starlette.py 84.68% <100.00%> (-0.27%) ⬇️
sentry_sdk/scope.py 82.40% <ø> (+0.58%) ⬆️
sentry_sdk/integrations/django/__init__.py 83.19% <0.00%> (-0.46%) ⬇️

... and 3 files with indirect coverage changes

sentrivana added a commit that referenced this pull request Mar 26, 2025
The docstring for `Scope.user` says it's deprecated in favor of
`Scope.set_user()`, but there is no user-facing warning. Add one so that
we can [drop the
property](#4193) in the
next major.

---------

Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
@sentrivana sentrivana marked this pull request as ready for review April 4, 2025 11:35
@sentrivana sentrivana requested a review from a team as a code owner April 4, 2025 11:35
@sentrivana sentrivana requested review from antonpirker and removed request for a team April 4, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant