Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TTFD measurement when API called too early #4297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

📜 Description

Sentry.reportFullyDisplayed now sets a flag if the ttid is not finished.
When the TTID finishes, if the flag is set, the TTFD is finished as well

💡 Motivation and Context

Fixes #3384

💚 How did you test it?

Unit tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

When the TTID finishes, if the flag is set, the TTFD is finished as well
@stefanosiano stefanosiano marked this pull request as ready for review March 28, 2025 15:22
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.29 ms 480.24 ms 47.95 ms
Size 1.58 MiB 2.22 MiB 655.02 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwrite TTFD measurement when API called too early
1 participant