-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Improve backend test performance by patching password hashing #1389
base: master
Are you sure you want to change the base?
⚡️ Improve backend test performance by patching password hashing #1389
Conversation
85712f8
to
05710bd
Compare
* Patch password hashing during tests
05710bd
to
5fe9712
Compare
This substantially reduces testing time - thank you! Only thing I noticed is that |
At least according to mypy, mypy output when using
I'm not sure what's the better option here. Do we ignore the type checker and provided signature for |
Improve performance of backend tests by patching password hashing during tests.
NOTE: To reduce interference with preexisting data, all existing users and items are now deleted before the tests are run.
This should not be noticable outside of testing, since all users and items already have been deleted after testing anyway.