core/state: store storageOrigin in one map #31488
Open
+26
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
Mar 26, 2025
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
force-pushed
the
state-storage-aio
branch
from
91b23cc to
6533018
Compare
| @@ -1213,7 +1213,7 @@ func (s *StateDB) commit(deleteEmptyObjects bool, noStorageWiping bool) (*stateU | |||
| // Run the storage updates concurrently to one another | |||
| workers.Go(func() error { | |||
| // Write any storage changes in the state object to its storage trie | |||
| update, set, err := obj.commit() | |||
| update, set, err := obj.commit(noStorageWiping) | |||
There was a problem hiding this comment.
I don't get why noStorageWiping is synonymous with rawStorageKey?
There was a problem hiding this comment.
Inside the state udpate, rawStorageKey == noStorageWiping, ref
go-ethereum/core/state/statedb.go
Line 1258 in 6533018
How about rename one of the names, leaving only rawStorageKey or noStorageWiping, to reduce the ambiguity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we don't need to store the storagesOrigin in two maps, store in one map is enough.