Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use pnpm/action-setup for pnpm #108

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Apr 5, 2025

Prerequisites checklist

What is the purpose of this pull request?

The pnpm-install job in the workflow .github/workflows/ci-build-all-pm.yml relies on a version of Corepack bundled with Node.js. The Node.js website https://nodejs.org/docs/latest/api/corepack.html states "... Corepack itself will no longer be distributed with future versions of Node.js." which would cause the workflow to break.

Following the pnpm package manager's documentation Continuous Integration > GitHub Actions, the installation method for pnpm in GitHub Actions is changed to using the JavaScript GitHub Action pnpm/action-setup@v4, replacing the need for Corepack.

What changes did you make? (Give an overview)

In the workflow .github/workflows/ci-build-all-pm.yml pnpm-install job, replace corepack with pnpm/action-setup@v4 following the example in Continuous Integration > GitHub Actions.

Related Issues

Is there anything you'd like reviewers to focus on?

Check that https://github.com/eslint/css/actions/workflows/ci-build-all-pm.yml completes successfully

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 5, 2025
@MikeMcC399
Copy link
Contributor Author

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 5, 2025 08:51
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 3554bcf into eslint:main Apr 8, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Apr 8, 2025
@MikeMcC399 MikeMcC399 deleted the ci/pnpm-action-setup branch April 9, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants