Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] indentation improvements #217255

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Apr 4, 2025

Summary

The formatter uses a tab size of 2 spaces. The editor should follow suit so that it is easy to keep the formatting.

Also, the editor should keep the current indentation automatically.

Screen.Recording.2025-04-04.at.1.47.44.PM.mov

@drewdaemon drewdaemon added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Apr 4, 2025
@drewdaemon drewdaemon changed the title [ES|QL] Match tab size in formatter [ES|QL] indentation improvements Apr 4, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / ObservabilityApp Observability Rules page Create rules form "after each" hook for "allows ES query rules to be created by users with only logs feature enabled"
  • [job] [logs] FTR Configs #40 / ObservabilityApp Observability Rules page Create rules form only logs feature enabled allows ES query rules to be created by users with only logs feature enabled
  • [job] [logs] Jest Tests #6 / Templates renders empty templates correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 244.2KB 244.2KB +10.0B

@drewdaemon drewdaemon marked this pull request as ready for review April 4, 2025 23:10
@drewdaemon drewdaemon requested a review from a team as a code owner April 4, 2025 23:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants