Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES 9.0] Remove body workaround (@elastic/kibana-security) #217222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afharo
Copy link
Member

@afharo afharo commented Apr 4, 2025

Summary

Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584.

We should be able to remove all usages of // @ts-expect-error elasticsearch@9.0.0 https://github.com/elastic/elasticsearch-js/issues/2584.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@afharo afharo self-assigned this Apr 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 4, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@afharo afharo added Feature:elasticsearch Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting elasticsearch-js-9 labels Apr 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 4, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Basic scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Basic scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme with client authentication
  • [job] [logs] Jest Tests #17 / API Keys grantAsInternalUser() calls grantApiKey with proper parameters for the Bearer scheme with client authentication
  • [job] [logs] Jest Tests #17 / API Keys with kibana privileges creates api key with application privileges as internal user
  • [job] [logs] Jest Tests #17 / API Keys with kibana privileges creates api key with application privileges as internal user
  • [job] [logs] FTR Configs #101 / saved objects tagging - functional tests feature controls tag management write privileges can bulk delete tags
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index if version in meta is lower than the current version
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index if version in meta is lower than the current version
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index without version in the meta
  • [job] [logs] Jest Tests #17 / Session index #initialize updates mappings for existing index without version in the meta

Metrics [docs]

✅ unchanged

History

cc @afharo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting elasticsearch-js-9 Feature:elasticsearch release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants