fix: docker release should be updated latest version using semantic version of latest tag #4887
Conversation
|
The change was tested with a test trigger on the push for the current branch: This solution was partially tested locally: |
vyavdoshenko
changed the title
| if docker pull ${registry}:latest &>/dev/null; then | ||
| echo "Found latest tag, checking its version..." | ||
| # Run the container to get its version | ||
| latest_full_version=$(docker run --rm --entrypoint /bin/sh ${registry}:latest -c "dragonfly --version | cut -d' ' -f2 | head -n 1") |
There was a problem hiding this comment.
this is unfortunate that the version is not stored in the image itself.
when running docker inspect ubuntu:latest
I see
...
"Labels": {
"org.opencontainers.image.ref.name": "ubuntu",
"org.opencontainers.image.version": "24.04"
}
meaning we could store the version using labels and then fetch the label instead of running the binary.
this can not be done now but we can specify the right label to simplify this code in the future.
this is what we specify now:
"org.opencontainers.image.created": "2025-03-30T07:56:05.960Z",
"org.opencontainers.image.description": "The fastest in-memory store",
"org.opencontainers.image.licenses": "NOASSERTION",
"org.opencontainers.image.ref.name": "ubuntu",
"org.opencontainers.image.revision": "a87fe66d1a7654b8f2ee2b7fe27687d582230888",
"org.opencontainers.image.source": "https://github.com/dragonflydb/dragonfly",
"org.opencontainers.image.title": "Dragonfly Production Image",
"org.opencontainers.image.url": "https://github.com/dragonflydb/dragonfly",
"org.opencontainers.image.vendor": "DragonflyDB LTD",
"org.opencontainers.image.version": "ubuntu-1.28.1-amd64"
I suggest changing org.opencontainers.image.version to be version only, i.e. 1.28.1
There was a problem hiding this comment.
I added processing with docker image inspect for:
- ubuntu-1.28.1-amd64
- 1.28.1 (as fallback)
The second chance will be:
- dragonfly --version
| fi | ||
|
|
||
| # Compare versions only if we have a latest version | ||
| should_update_latest=true |
There was a problem hiding this comment.
lets factor out this to function semver_cmp for readability
There was a problem hiding this comment.
Pull Request Overview
This PR updates the docker release workflow to ensure that the "latest" tag is updated using a semantic versioning check.
- Added logic to remove a leading "v" from version strings.
- Implemented a semantic version comparison between the new tag and the current latest tag.
- Adjusted manifest creation and push steps based on the comparison result.
Comments suppressed due to low confidence (1)
.github/workflows/docker-release2.yml:188
- Ensure that the 'current_version' variable always contains a valid semantic version (major.minor.patch). Consider adding a validation step to handle unexpected version string formats.
IFS='.' read -ra CURRENT_PARTS <<< "$current_version"
fixed: #4831