[wip] fix: make FreeMemWithEvictionStep atomic #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <kostas@dragonflydb.io>
kostasrim
commented
Apr 3, 2025
| }; | ||
|
|
||
| shard_set->pool()->AwaitBrief(std::move(cb)); | ||
| } | ||
| } | ||
|
|
||
| void DbSlice::SendQueuedInvalidationMessagesAsync() { |
There was a problem hiding this comment.
We drained it before because we blocked. Now we don't.
TODO investigate: we should call this also from heartbeat (so on the second iteration it drains it if there were items added).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeMemWithEvictionStep was not atomic yet was used by a flow -- RetireExpireAndEvict() -- which should be atomic. Therefore, we make this function atomic (since it's only used by that flow).
Resolves #4875