feat: debug compression <type>

[romange]

Extend debug compression to support value types. if no type is given, falls back to testing keys compressability.

[Copilot]

Pull Request Overview

This PR extends the "debug compression" command to support value types while falling back to key compression when no type is provided.

• Updated the Compression command interface to accept command arguments.
• Enhanced the DoComputeHist function to process various object types (STRING, ZSET, LIST, HASH) based on an optional parameter.
• Updated the help message and command dispatch to reflect the new argument.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/server/debugcmd.h	Updated the Compression method signature to support arguments.
src/server/debugcmd.cc	Modified DoComputeHist and Compression implementations to support processing different object types.

Comments suppressed due to low confidence (1)

src/server/debugcmd.cc:327

• Consider explicitly handling cases where the provided type does not match any of the supported types (OBJ_STRING, OBJ_ZSET, OBJ_LIST, OBJ_HASH) to clarify the behavior in such scenarios.

      }

[Copilot]

Pull Request Overview

This PR extends the debug compression command to support an optional value type argument. When provided, the command computes compressibility for values of the specified type; otherwise, it falls back to testing keys’ compressibility.

• Updated the function signature for Compression in both header and implementation files.
• Modified the DoComputeHist function to handle an optional type parameter and dispatch accordingly.
• Adjusted the help message for the COMPRESSION command.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/server/debugcmd.h	Updated the Compression function signature to accept CmdArgList
src/server/debugcmd.cc	Passed the optional type from the command, updated DoComputeHist accordingly, and improved the help message

Comments suppressed due to low confidence (3)

src/server/debugcmd.cc:297

• When checking for the absence of a type, ensure that subsequent comparisons clearly reference the intended value. Consider explicitly dereferencing the optional when comparing it to constant values.

if (!type) {

src/server/debugcmd.cc:299

• Ensure that comparing an optional type directly to a constant (e.g. OBJ_STRING) behaves as expected; using '*type' after confirming it has a value might improve clarity and correctness.

else if (type == OBJ_STRING && it->second.ObjType() == OBJ_STRING) {

src/server/debugcmd.cc:547

• [nitpick] Consider merging the split help description lines into a single, coherent message or ensuring proper formatting so that users clearly understand the command usage.

"COMPRESSION [type]"

[romange]

@BorysTheDev ping