Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AND optimization #2923

Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix AND optimization #2923

merged 1 commit into from
Apr 7, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Apr 4, 2025

This PR fixes AND optimizations where TRUE & x -> x.
Probably should've seen this coming given our bug fix with OR here,

fixes: dolthub/dolt#9074

@jycor jycor requested a review from fulghum April 4, 2025 20:39
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jycor jycor merged commit a6580a3 into main Apr 7, 2025
9 checks passed
@jycor jycor deleted the james/and branch April 7, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect optimization of AND operation in expression in WHERE clause
2 participants