Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments: Enhancements , strategy specific to certain LLMs #1733

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ManishMadan2882
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    - Files are stored as <settings.UPLOAD_FOLDER>/<user>/attachments/ObjectId/filename.ext
    - Show warning(!) on failing uploads to the frontend
    - Add functionality to remove files(x)
    - OpenAI specific approach to send files(pdfs/docs for now)
    {'role': 'user', 'content': [{'type': 'text', 'text': 'Hi'}, {'type': 'file', 'file': {'file_id': 'file-XYZ'}}]}
  • Why was this change needed? (You can also link to an open issue here)
    - Continuation of the Attachments feature

Copy link

vercel bot commented Apr 6, 2025

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 7.24638% with 128 lines in your changes missing coverage. Please review.

Project coverage is 29.13%. Comparing base (f6c88da) to head (55bd90f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
application/llm/openai.py 8.51% 86 Missing ⚠️
application/agents/llm_handler.py 4.16% 23 Missing ⚠️
application/worker.py 0.00% 14 Missing ⚠️
application/api/user/routes.py 0.00% 3 Missing ⚠️
application/api/answer/routes.py 0.00% 1 Missing ⚠️
application/llm/base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   29.59%   29.13%   -0.46%     
==========================================
  Files          85       85              
  Lines        4957     5069     +112     
==========================================
+ Hits         1467     1477      +10     
- Misses       3490     3592     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2025 7:07pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants