Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpate proto change check workflow #16281

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Apr 3, 2025

Description

Update indexer-protos-sdk-update workflow to trigger SDK updates when proto changes are detected. Previously, the workflow would fail if generated proto code changed, but now it detects these changes and sets an output variable that triggers the SDK update job when necessary.

Test Plan

Copy link

trunk-io bot commented Apr 3, 2025

⏱️ 45m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-e2e-test / forge 14m 🟩
rust-doc-tests 8m 🟩
execution-performance / test-target-determinator 5m 🟩
check-dynamic-deps 5m 🟩🟩
test-target-determinator 5m 🟩
rust-cargo-deny 3m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 54s 🟩🟩
semgrep/ci 53s 🟩🟩
file_change_determinator 24s 🟩🟩
file_change_determinator 11s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 6s 🟩🟩
permission-check 4s 🟩🟩
permission-check 3s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 21m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

yuunlimm commented Apr 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm marked this pull request as ready for review April 3, 2025 18:49
@yuunlimm yuunlimm requested a review from a team as a code owner April 3, 2025 18:49
@yuunlimm yuunlimm requested a review from a team April 4, 2025 18:46
@yuunlimm yuunlimm enabled auto-merge (squash) April 7, 2025 16:22

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

✅ Forge suite compat success on da4d9d451fa6e3cd5583d4a9fee4d609588afb30 ==> e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5

Compatibility test results for da4d9d451fa6e3cd5583d4a9fee4d609588afb30 ==> e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5 (PR)
1. Check liveness of validators at old version: da4d9d451fa6e3cd5583d4a9fee4d609588afb30
compatibility::simple-validator-upgrade::liveness-check : committed: 2664.24 txn/s, submitted: 2763.10 txn/s, failed submission: 49.08 txn/s, expired: 98.86 txn/s, latency: 4637.15 ms, (p50: 3600 ms, p70: 3800, p90: 13000 ms, p99: 15800 ms), latency samples: 219322
2. Upgrading first Validator to new version: e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2999.41 txn/s, latency: 9719.12 ms, (p50: 10400 ms, p70: 12000, p90: 12700 ms, p99: 12700 ms), latency samples: 65560
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3035.45 txn/s, latency: 11102.67 ms, (p50: 12300 ms, p70: 12700, p90: 12800 ms, p99: 13100 ms), latency samples: 117160
3. Upgrading rest of first batch to new version: e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3050.13 txn/s, latency: 9516.55 ms, (p50: 10600 ms, p70: 11800, p90: 12500 ms, p99: 12600 ms), latency samples: 67820
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2998.75 txn/s, latency: 11155.70 ms, (p50: 12300 ms, p70: 12900, p90: 13200 ms, p99: 13200 ms), latency samples: 114600
4. upgrading second batch to new version: e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5077.43 txn/s, latency: 5960.02 ms, (p50: 6700 ms, p70: 7100, p90: 7800 ms, p99: 8000 ms), latency samples: 101300
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5057.61 txn/s, latency: 6655.03 ms, (p50: 7000 ms, p70: 7600, p90: 8300 ms, p99: 8300 ms), latency samples: 181140
5. check swarm health
Compatibility test for da4d9d451fa6e3cd5583d4a9fee4d609588afb30 ==> e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5 passed
Test Ok

Copy link
Contributor

github-actions bot commented Apr 7, 2025

✅ Forge suite framework_upgrade success on da4d9d451fa6e3cd5583d4a9fee4d609588afb30 ==> e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5

Compatibility test results for da4d9d451fa6e3cd5583d4a9fee4d609588afb30 ==> e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5 (PR)
Upgrade the nodes to version: e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1729.80 txn/s, submitted: 1735.10 txn/s, failed submission: 5.30 txn/s, expired: 5.30 txn/s, latency: 1691.39 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 4600 ms), latency samples: 156581
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1608.13 txn/s, submitted: 1613.84 txn/s, failed submission: 5.71 txn/s, expired: 5.71 txn/s, latency: 1799.36 ms, (p50: 1600 ms, p70: 1900, p90: 2700 ms, p99: 3600 ms), latency samples: 146520
5. check swarm health
Compatibility test for da4d9d451fa6e3cd5583d4a9fee4d609588afb30 ==> e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5 passed
Upgrade the remaining nodes to version: e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1709.73 txn/s, submitted: 1715.10 txn/s, failed submission: 5.37 txn/s, expired: 5.37 txn/s, latency: 1761.37 ms, (p50: 1600 ms, p70: 1800, p90: 2500 ms, p99: 3600 ms), latency samples: 152760
Test Ok

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

✅ Forge suite realistic_env_max_load success on e013ff6c4675e0b9b8e97c7ed14d3fe2c3a16db5

two traffics test: inner traffic : committed: 4357.32 txn/s, latency: 9119.30 ms, (p50: 9200 ms, p70: 9400, p90: 9900 ms, p99: 11100 ms), latency samples: 1657100
two traffics test : committed: 99.98 txn/s, latency: 2280.27 ms, (p50: 1400 ms, p70: 1700, p90: 5700 ms, p99: 8800 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 7.633, avg: 6.837", "ConsensusProposalToOrdered: max: 0.293, avg: 0.287", "ConsensusOrderedToCommit: max: 0.729, avg: 0.496", "ConsensusProposalToCommit: max: 1.016, avg: 0.783"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.66s no progress at version 10173 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.75s no progress at version 690739 (avg 0.69s) [limit 16].
Test Ok

@yuunlimm yuunlimm merged commit c25cf03 into main Apr 7, 2025
87 of 90 checks passed
@yuunlimm yuunlimm deleted the 04-03-udpate_proto_change_check_workflow branch April 7, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants