Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(circleci): Fix for incremental jobs cherry-pick merge #8346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

magichair
Copy link
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

Fixes the prior cherry-pick that was out of date and using the wrong field for #8341

Updates the where clause for querying the new incremental function to use the correct column name created_at rather than created_date. This also updates other dated references to created_date.

Does this close any open issues?

No

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. cherrypick This PR is cherry-picked from another branch component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Mar 19, 2025
@Nickcw6
Copy link
Contributor

Nickcw6 commented Mar 19, 2025

Looks like this PR didn't end up getting cherrypicked:

#7757

This added the created_date fields to which the plugin refers, as created_at is the timestamp a row was added to the DevLake DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick This PR is cherry-picked from another branch component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants