Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider first comment to be of type Review #8332

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tcarac
Copy link

@tcarac tcarac commented Mar 11, 2025

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • [] I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

Takes into a account Pr Type to determine if it should be considered as the first Pr in pickup time

Does this close any open issues?

#8317

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@tcarac
Copy link
Author

tcarac commented Mar 11, 2025

Don't see any specific related tests to this function or classes. Are these to be considered part of the csv testing within dataflow ?

@tcarac tcarac marked this pull request as ready for review March 11, 2025 12:58
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Mar 11, 2025
Copy link

@AnkeshThakur AnkeshThakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@klesh
Copy link
Contributor

klesh commented Mar 14, 2025

It seems that only the Github plugin respects this type field, which means this patch may not work as expected on other plugins.
I think this issue could be addressed in the following ways:

  1. Update all other plugins to fill in this field.
  2. Accept both REVIEW and an empty string for the type column.

@klesh
Copy link
Contributor

klesh commented Mar 19, 2025

Hi, @tcarac e2e tests is failing, I think the csv files located in https://github.com/apache/incubator-devlake/tree/main/backend/plugins/dora/e2e/change_lead_time need to be updated, try adding type column to pull_request_comments.csv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants